refactor(makeCache)!: make params an object #11172
Open
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `Options.makeCache` now sends all of its parameters in an object rather than 3 individual parameters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Options.makeCachenow sends all of its parameters in an object rather than 3 individual parametersPlease describe the changes this PR makes and why it should be merged:
Finally getting around to this todo. Switching the parameter order doesn't really make sense, and it didn't make sense to make the type optional anyways, so I've made it an object instead to ease access to the parameter that is actually wanted, as it may often not be the first one.
Status and versioning classification: